Skip to content

Fix edgecase in batch size scaling tuner alg #21187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2025
Merged

Fix edgecase in batch size scaling tuner alg #21187

merged 3 commits into from
Sep 9, 2025

Conversation

SkafteNicki
Copy link
Collaborator

@SkafteNicki SkafteNicki commented Sep 9, 2025 •
edited
Loading

What does this PR do?

Fixes #18426
Edge case happens when max_trials is hit and the last tested value fits in memory. In this case the algorithm will double the size before exiting, returning a batch size which is untested if it fits in memory. PR makes sure we exit at the right time if max_trials condition is hit.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21187.org.readthedocs.build/en/21187/

@SkafteNicki SkafteNicki requested a review from lantiga as a code owner September 9, 2025 03:52
@SkafteNicki SkafteNicki added the bug Something isn't working label Sep 9, 2025
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 9, 2025
@SkafteNicki SkafteNicki mentioned this pull request Sep 9, 2025
Draft
7 tasks
@Borda Borda merged commit 3998b5d into Lightning-AI:master Sep 9, 2025
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
bug Something isn't working pl Generic label for PyTorch Lightning package tuner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tuner's scale_batch_size edgecase resulting in a bug
2 participants
@SkafteNicki @Borda